Hello Nicolas,
On 07/15/2016 02:17 PM, Nicolas George wrote:
Therefore I would like to keep the fifo muxer as Jan submitted it, without
EAGAIN support. If there is a use case for non-blockingingness in a sense
you use the phrase, then it can be added later.
I am against it. As it is, I consider it is way too specific to be added to
the code base.
We've talked with Marton and decided that I will try to implement the
non-blocking mode as described in my previous e-mail as a separate patch
at the top of current fifo muxer (also with necessary API patches as
separate patches).
However, I don't see a reason why the fifo muxer couldn't be
accepted to codebase before the patch adding AVFMT_FLAG_NONBLOCK support
is completed - non-blocking mode will not be used in FFmpeg anyway.
Although developers using libavformat can benefit from nonblocking fifo
muxer, there is no reason not to provide functionality it adds to ffmpeg
users (and adding AVFMT_FLAG_NONBLOCK support will not change the
functionality it provides for users).
So, I would like to send current version of fifo muxer to the ML
and I hope we can deal separately with the support for
AVFMT_FLAG_NONBLOCK later. I think this way it will also simplify the
review process. Can we do it this way? :)
Regards,
Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
