On 7/7/2016 10:55 PM, Michael Niedermayer wrote: > On Wed, Jul 06, 2016 at 08:25:26PM -0300, James Almer wrote: >> While not enforced, RFC 5334 mentions that the .ogg extension should >> be used for Vorbis audio files only. >> >> Signed-off-by: James Almer <jamr...@gmail.com> >> --- >> This patch turns the ogg muxer into an audio only muxer to follow >> the RFC's recommendation. The next patch in the set adds a new ogv >> muxer to properly deal with video files. >> >> I doubt anyone out there tries to mux theora video using the .ogg >> extension (even ffmpeg2theora seems to default to .ogv), so it's >> unlikely it will affect people's normal workflow. >> But if someone is against it then this patch can either be dropped >> or changed to only remove flac from the defaults. That way video >> can still be muxed. >> >> I personally prefer to apply this patch as is, though. >> >> libavformat/oggenc.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) > > breaks fate
Yes, forgot to run fate for this set. It's caused by the fact the ogg muxer can't mux video streams anymore after this patch. I want to know if the actual change is acceptable first, then I'll resend the set with fate tests updated to use ogv muxer and similar changes. > > --- ./tests/ref/lavf-fate/ogg_vp3 2016-07-04 23:15:26.551386870 +0200 > +++ tests/data/fate/lavf-fate-ogg_vp3 2016-07-08 03:51:46.269196793 +0200 > @@ -1,3 +0,0 @@ > -4bd51dac3194fa88ae33767c25b4b1e6 *./tests/data/lavf-fate/lavf.ogg > -417621 ./tests/data/lavf-fate/lavf.ogg > -./tests/data/lavf-fate/lavf.ogg CRC=0x037e3e79 > Test lavf-fate-ogg_vp3 failed. Look at tests/data/fate/lavf-fate-ogg_vp3.err > for details. > make: *** [fate-lavf-fate-ogg_vp3] Error 1 > make: *** Waiting for unfinished jobs.... > > [...] > > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
