On Mon, Jun 20, 2016 at 01:07:09PM +0000, Carl Eugen Hoyos wrote:
> Clément Bœsch <u <at> pkh.me> writes:
>
> > +static int pgmyuv_probe(AVProbeData *p)
> > +{
> > + int ret = pgmx_probe(p);
> > + return ret && av_match_ext(p->filename, "pgmyuv") ? ret : 0;
>
> You could add a comment that this format was invented within
> FFmpeg, I hadn't realized this.I'm not sure the probe code is really the best place to do that but added locally anyway > And you could check for positive resolutions if you want to > improve probing. Yeah, probing could be improved, but it requires some line skipping logic (empty lines, comments, etc) I wasn't that motivated to write (probably due to a traumatic history with text subtitles). > Did you run the probe test for the new functions? Should I pass special parameters? testing size=1 testing size=2 testing size=4 testing size=8 Failure of vqf probing code with score=50 type=3 p=C2A size=8 Failure of mov,mp4,m4a,3gp,3g2,mj2 probing code with score=50 type=3 p=FD1 size=8 Failure of 3dostr probing code with score=66 type=3 p=E2 size=8 Failure of mov,mp4,m4a,3gp,3g2,mj2 probing code with score=100 type=3 p=75 size=8 testing size=16 Failure of musx probing code with score=40 type=3 p=A6A size=16 Failure of alias_pix probing code with score=51 type=0 p=CBA size=16 testing size=32 testing size=64 Failure of mpc8 probing code with score=49 type=3 p=85A size=64 testing size=128 testing size=256 testing size=512 testing size=1024 testing size=2048 testing size=4096 testing size=8192 testing size=16384 -- Clément B.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
