On Sun, Jun 12, 2016 at 04:14:56PM -0500, Kyle Swanson wrote: > Hi all, > > Here's three patches. These are still WIP and not ready to be pushed. > > 0001-avfilter-add-libebur128-port.patch > This first patch ports libebur128 to ffmpeg. I haven't re-indented > these yet, so please diff `ebur128.c' and `ebur128.h' with the > original libebur128 files[1][2] to see what has changed. Also included > is `queue.h' which comes from BSD, which AFAIK should be distributable > if we decide to go this route. All these files still need their > license header, as libebur128 is MIT licensed and needs its own > copyright message. One other thing to take a look at is the section > with the sse2 optimizations - does FFmpeg already have a macro we > could use for this? > > > 0002-avfilter-af_loudnorm-use-internal-ebur128-api.patch > This patch removes the libebur128 dependency for the loudnorm and uses > the new internal ebur128 API. > > > 0003-avfilter-af_astats-add-ebur128-stats.patch > This patch adds ebur128 stats to the astats filter. Because of the > extra computation required to calculate ebur128 stats, I decided that > these modes should be explicitly specified via a few new filter > parameters. From my perspective, it makes more sense for this to live > in the astats filter instead of a completely separate filter > (f_ebur128). I'd vote for removing the current ebur128 filter, but if > we wanted to keep it it should be ported to use the new ebur128 code. > > Thanks, > Kyle > > [1] > https://raw.githubusercontent.com/jiixyj/libebur128/master/ebur128/ebur128.h > [2] > https://raw.githubusercontent.com/jiixyj/libebur128/master/ebur128/ebur128.c
something needs to be updated to make fate-source pass: --- ./tests/ref/fate/source 2016-06-12 20:29:44.811132775 +0200 +++ tests/data/fate/source 2016-06-13 02:30:48.715589174 +0200 @@ -7,7 +7,10 @@ libavcodec/log2_tab.c libavcodec/reverse.c libavdevice/file_open.c +libavfilter/ebur128.c +libavfilter/ebur128.h libavfilter/log2_tab.c +libavfilter/queue.h libavformat/file_open.c libavformat/golomb_tab.c libavformat/log2_tab.c @@ -26,3 +29,5 @@ compat/avisynth/windowsPorts/windows2linux.h compat/float/float.h compat/float/limits.h +libavfilter/ebur128.h +libavfilter/queue.h Test source failed. Look at tests/data/fate/source.err for details. [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Complexity theory is the science of finding the exact solution to an approximation. Benchmarking OTOH is finding an approximation of the exact
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
