On Sat, Jun 04, 2016 at 02:42:57PM +0200, Jan Sebechlebsky wrote: > > > On 06/03/2016 07:55 PM, Michael Niedermayer wrote: > >On Fri, Jun 03, 2016 at 02:04:00PM +0200, sebechlebsky...@gmail.com wrote: > >>From: Jan Sebechlebsky <sebechlebsky...@gmail.com> > >> > >>Fifo was reallocating always to twice of the requested size. > >>This fixes it to reallocate to requested size, or twice of the > >>original size - whichever is greater. > >> > >>Signed-off-by: Jan Sebechlebsky <sebechlebsky...@gmail.com> > >>--- > >> I believe the intended behaviour was as described in commit message > >> and FFMAX(size,2*size) is a mistake. > >the point behind teh FFMAX was to protect against a overflow of > >2*size but your suggestion is probably better and would reduce memory > >use, so applied > > > >thanks > You're welcome, at least me missing the point was good for something :) > Would you mind if I added function av_fifo_generic_write_grow to > libavutil/fifo.c which would grow the fifo if there is not enough > space for the element to be added?
if theres a case that would use it such function is not thread safe though while the normal read/write should be (this should be documented) [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize last or never when they are wrong.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
