Hi Michael, I have found some parameters that produce the same results in x64 and x32 architectures. Here is the patch :)
Thanks, Petru Rares. ________________________________________ From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> on behalf of Michael Niedermayer <mich...@niedermayer.cc> Sent: Saturday, May 14, 2016 3:50:03 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] fate: add aecho test On Sat, May 14, 2016 at 09:07:17AM +0000, Petru Rares Sincraian wrote: > > > Hi there, > > Here I add a new test for aecho filter. > fate/filter-audio.mak | 5 > ref/fate/filter-aecho | 286 > ++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 291 insertions(+) > efd0670e8f0c0c23e9d1392052b03ac4b7e047f0 0001-fate-add-aecho-test.patch > From 25e8de6f4caa08a1903a6756ca718ef06722d116 Mon Sep 17 00:00:00 2001 > From: Petru Rares Sincraian <psincra...@outlook.com> > Date: Sat, 14 May 2016 11:04:25 +0200 > Subject: [PATCH] fate: add aecho test this fails on x86-32 --- ffmpeg/tests/ref/fate/filter-aecho 2016-05-14 13:33:43.477820778 +0200 +++ tests/data/fate/filter-aecho 2016-05-14 15:16:00.441950067 +0200 @@ -46,241 +46,241 @@ 0, 40960, 40960, 1024, 4096, 0x7c4ce7e9 0, 41984, 41984, 1024, 4096, 0x5eddeb19 0, 43008, 43008, 1024, 4096, 0x351c08c4 -0, 44032, 44032, 1024, 4096, 0x30c6db8f -0, 45056, 45056, 1024, 4096, 0x1c4b3258 -0, 46080, 46080, 1024, 4096, 0xe32d157e +0, 44032, 44032, 1024, 4096, 0x4dd4db91 +0, 45056, 45056, 1024, 4096, 0x07ad3256 +0, 46080, 46080, 1024, 4096, 0xe6131580 0, 47104, 47104, 1024, 4096, 0xbbe9e635 -0, 48128, 48128, 1024, 4096, 0x7e8214dc -0, 49152, 49152, 1024, 4096, 0xd671e4c1 -0, 50176, 50176, 1024, 4096, 0xd268f457 -0, 51200, 51200, 1024, 4096, 0x6051018e +0, 48128, 48128, 1024, 4096, 0x8f4014de +0, 49152, 49152, 1024, 4096, 0xbc53e4bf +0, 50176, 50176, 1024, 4096, 0xf2b6f459 +0, 51200, 51200, 1024, 4096, 0x83350192 you can test that with somethng like ./configure --arch=x86_32 --target-os=linux --extra-cflags=-m32 --extra-ldflags=-m32 --enable-cross-compile aecho uses floats so rounding and precission differences can cause differences between platforms you could improve aecho so it does not depend on floats for filtering of s16 samples but maybe you can find parameters that give the same result on all platforms without that or a small reference file would need to be added and tiny_psnr used for comparing [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 3 "Rare item" - "Common item with rare defect or maybe just a lie" "Professional" - "'Toy' made in china, not functional except as doorstop" "Experts will know" - "The seller hopes you are not an expert"
From 5a3be60397e2f7bc0d84232736c8d44508bfbeff Mon Sep 17 00:00:00 2001 From: Petru Rares Sincraian <psincra...@outlook.com> Date: Sun, 22 May 2016 09:45:49 +0200 Subject: [PATCH] fate: add aecho test --- tests/fate/filter-audio.mak | 5 + tests/ref/fate/filter-aecho | 265 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 270 insertions(+) create mode 100644 tests/ref/fate/filter-aecho diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak index 7f7e520..5e5f1f9 100644 --- a/tests/fate/filter-audio.mak +++ b/tests/fate/filter-audio.mak @@ -3,6 +3,11 @@ fate-filter-adelay: tests/data/asynth-44100-2.wav fate-filter-adelay: SRC = $(TARGET_PATH)/tests/data/asynth-44100-2.wav fate-filter-adelay: CMD = framecrc -i $(SRC) -af adelay=42 +FATE_AFILTER-$(call FILTERDEMDECENCMUX, AECHO, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-aecho +fate-filter-aecho: tests/data/asynth-44100-2.wav +fate-filter-aecho: SRC = $(TARGET_PATH)/tests/data/asynth-44100-2.wav +fate-filter-aecho: CMD = framecrc -i $(SRC) -af aecho=0.5:0.5:32:0.5 + tests/data/hls-list.m3u8: TAG = GEN tests/data/hls-list.m3u8: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data $(M)$(TARGET_EXEC) $(TARGET_PATH)/$< \ diff --git a/tests/ref/fate/filter-aecho b/tests/ref/fate/filter-aecho new file mode 100644 index 0000000..f564fcc --- /dev/null +++ b/tests/ref/fate/filter-aecho @@ -0,0 +1,265 @@ +#tb 0: 1/44100 +#media_type 0: audio +#codec_id 0: pcm_s16le +#sample_rate 0: 44100 +#channel_layout 0: 3 +0, 0, 0, 1024, 4096, 0x3019edd5 +0, 1024, 1024, 1024, 4096, 0x2df2fe2f +0, 2048, 2048, 1024, 4096, 0xde37ff37 +0, 3072, 3072, 1024, 4096, 0xe933f6a5 +0, 4096, 4096, 1024, 4096, 0xd5acf1f3 +0, 5120, 5120, 1024, 4096, 0x82a6f903 +0, 6144, 6144, 1024, 4096, 0x1792f923 +0, 7168, 7168, 1024, 4096, 0x01500504 +0, 8192, 8192, 1024, 4096, 0xe306efc3 +0, 9216, 9216, 1024, 4096, 0x3abcecaf +0, 10240, 10240, 1024, 4096, 0x5059f861 +0, 11264, 11264, 1024, 4096, 0xc172ff61 +0, 12288, 12288, 1024, 4096, 0x857dfc1b +0, 13312, 13312, 1024, 4096, 0x5899ed35 +0, 14336, 14336, 1024, 4096, 0x9ae9f709 +0, 15360, 15360, 1024, 4096, 0xd5620036 +0, 16384, 16384, 1024, 4096, 0xc5ba0940 +0, 17408, 17408, 1024, 4096, 0x0c3af2ff +0, 18432, 18432, 1024, 4096, 0x5eddf1b1 +0, 19456, 19456, 1024, 4096, 0x9ec8f84d +0, 20480, 20480, 1024, 4096, 0x8a4f00ee +0, 21504, 21504, 1024, 4096, 0x0cd3fbe7 +0, 22528, 22528, 1024, 4096, 0x2ce0f199 +0, 23552, 23552, 1024, 4096, 0x9086e9bb +0, 24576, 24576, 1024, 4096, 0x0d6efb0b +0, 25600, 25600, 1024, 4096, 0x9dee020c +0, 26624, 26624, 1024, 4096, 0x96aff453 +0, 27648, 27648, 1024, 4096, 0xe1e9f177 +0, 28672, 28672, 1024, 4096, 0x13b8f893 +0, 29696, 29696, 1024, 4096, 0x4f3a01c8 +0, 30720, 30720, 1024, 4096, 0xa498fa25 +0, 31744, 31744, 1024, 4096, 0x0cd3f293 +0, 32768, 32768, 1024, 4096, 0x6de2eb8f +0, 33792, 33792, 1024, 4096, 0x0a0d01dc +0, 34816, 34816, 1024, 4096, 0xde37ff37 +0, 35840, 35840, 1024, 4096, 0xe933f6a5 +0, 36864, 36864, 1024, 4096, 0xd5acf1f3 +0, 37888, 37888, 1024, 4096, 0x82a6f903 +0, 38912, 38912, 1024, 4096, 0x1792f923 +0, 39936, 39936, 1024, 4096, 0x01500504 +0, 40960, 40960, 1024, 4096, 0xe306efc3 +0, 41984, 41984, 1024, 4096, 0x3abcecaf +0, 43008, 43008, 1024, 4096, 0x5059f861 +0, 44032, 44032, 1024, 4096, 0x9128d187 +0, 45056, 45056, 1024, 4096, 0x61471c76 +0, 46080, 46080, 1024, 4096, 0xd4057d4f +0, 47104, 47104, 1024, 4096, 0xe5fed87f +0, 48128, 48128, 1024, 4096, 0x5b0d059a +0, 49152, 49152, 1024, 4096, 0xfba4c1ad +0, 50176, 50176, 1024, 4096, 0x4c83f489 +0, 51200, 51200, 1024, 4096, 0xdbebe473 +0, 52224, 52224, 1024, 4096, 0x86efd467 +0, 53248, 53248, 1024, 4096, 0x1919f2f1 +0, 54272, 54272, 1024, 4096, 0x745b12d8 +0, 55296, 55296, 1024, 4096, 0xca86ff49 +0, 56320, 56320, 1024, 4096, 0x2914fdf3 +0, 57344, 57344, 1024, 4096, 0xf949f24f +0, 58368, 58368, 1024, 4096, 0x6436f791 +0, 59392, 59392, 1024, 4096, 0x693eebaf +0, 60416, 60416, 1024, 4096, 0xd0740bf0 +0, 61440, 61440, 1024, 4096, 0x08690478 +0, 62464, 62464, 1024, 4096, 0x23a8e259 +0, 63488, 63488, 1024, 4096, 0xba2d0152 +0, 64512, 64512, 1024, 4096, 0xbe65117e +0, 65536, 65536, 1024, 4096, 0xc8710c58 +0, 66560, 66560, 1024, 4096, 0x25db1d60 +0, 67584, 67584, 1024, 4096, 0xf960016e +0, 68608, 68608, 1024, 4096, 0x4db0f367 +0, 69632, 69632, 1024, 4096, 0x4154e591 +0, 70656, 70656, 1024, 4096, 0x8c95162c +0, 71680, 71680, 1024, 4096, 0x2502ffa9 +0, 72704, 72704, 1024, 4096, 0xe66a0792 +0, 73728, 73728, 1024, 4096, 0x6837e7fd +0, 74752, 74752, 1024, 4096, 0x9613e317 +0, 75776, 75776, 1024, 4096, 0xe087ea1f +0, 76800, 76800, 1024, 4096, 0x625ae70f +0, 77824, 77824, 1024, 4096, 0xd9b7fbbb +0, 78848, 78848, 1024, 4096, 0xb2f800e0 +0, 79872, 79872, 1024, 4096, 0x4fb0134c +0, 80896, 80896, 1024, 4096, 0xf90ed3ab +0, 81920, 81920, 1024, 4096, 0x8c13fd53 +0, 82944, 82944, 1024, 4096, 0xdf26d95b +0, 83968, 83968, 1024, 4096, 0x45e707fc +0, 84992, 84992, 1024, 4096, 0xd576fe23 +0, 86016, 86016, 1024, 4096, 0x168405f4 +0, 87040, 87040, 1024, 4096, 0x4a78db97 +0, 88064, 88064, 1024, 4096, 0x6d87f713 +0, 89088, 89088, 1024, 4096, 0x30750408 +0, 90112, 90112, 1024, 4096, 0xb011e7b5 +0, 91136, 91136, 1024, 4096, 0x19090af4 +0, 92160, 92160, 1024, 4096, 0x3122f1a7 +0, 93184, 93184, 1024, 4096, 0x3dc4b113 +0, 94208, 94208, 1024, 4096, 0x23c4ec7b +0, 95232, 95232, 1024, 4096, 0x3340159a +0, 96256, 96256, 1024, 4096, 0xb06cda91 +0, 97280, 97280, 1024, 4096, 0xd17445ec +0, 98304, 98304, 1024, 4096, 0xd222d3a1 +0, 99328, 99328, 1024, 4096, 0xd855e61d +0, 100352, 100352, 1024, 4096, 0x444eebc5 +0, 101376, 101376, 1024, 4096, 0xad3607c0 +0, 102400, 102400, 1024, 4096, 0x549b1aca +0, 103424, 103424, 1024, 4096, 0x7c6a0a1a +0, 104448, 104448, 1024, 4096, 0x04d2b3e9 +0, 105472, 105472, 1024, 4096, 0xf15d0216 +0, 106496, 106496, 1024, 4096, 0x5d15f709 +0, 107520, 107520, 1024, 4096, 0x47a7178e +0, 108544, 108544, 1024, 4096, 0x2aa5e665 +0, 109568, 109568, 1024, 4096, 0x2a9f1a08 +0, 110592, 110592, 1024, 4096, 0xeaa6e103 +0, 111616, 111616, 1024, 4096, 0x8ae100d6 +0, 112640, 112640, 1024, 4096, 0x9585251c +0, 113664, 113664, 1024, 4096, 0x5eb2289a +0, 114688, 114688, 1024, 4096, 0x0d0c0cfc +0, 115712, 115712, 1024, 4096, 0x7e5cd58f +0, 116736, 116736, 1024, 4096, 0xca3fc9c7 +0, 117760, 117760, 1024, 4096, 0xdda3ebe7 +0, 118784, 118784, 1024, 4096, 0x084dcb41 +0, 119808, 119808, 1024, 4096, 0x0adc2a9c +0, 120832, 120832, 1024, 4096, 0x64b0fa0f +0, 121856, 121856, 1024, 4096, 0x225ffadd +0, 122880, 122880, 1024, 4096, 0x40b0a487 +0, 123904, 123904, 1024, 4096, 0xc2edf0f3 +0, 124928, 124928, 1024, 4096, 0x5078d595 +0, 125952, 125952, 1024, 4096, 0x4ac9bb29 +0, 126976, 126976, 1024, 4096, 0x8a50ad77 +0, 128000, 128000, 1024, 4096, 0xf6bbebc7 +0, 129024, 129024, 1024, 4096, 0x9d33ca29 +0, 130048, 130048, 1024, 4096, 0x863b9ba7 +0, 131072, 131072, 1024, 4096, 0x41cbf17f +0, 132096, 132096, 1024, 4096, 0x519df567 +0, 133120, 133120, 1024, 4096, 0x59b50359 +0, 134144, 134144, 1024, 4096, 0x5640f0fc +0, 135168, 135168, 1024, 4096, 0x547df2b8 +0, 136192, 136192, 1024, 4096, 0xae6af2a8 +0, 137216, 137216, 1024, 4096, 0xb370f9ee +0, 138240, 138240, 1024, 4096, 0x0d691a7f +0, 139264, 139264, 1024, 4096, 0x8b2cf30d +0, 140288, 140288, 1024, 4096, 0x8868efce +0, 141312, 141312, 1024, 4096, 0x6602eb88 +0, 142336, 142336, 1024, 4096, 0x5fbbefd4 +0, 143360, 143360, 1024, 4096, 0xdf81e435 +0, 144384, 144384, 1024, 4096, 0x06b4e637 +0, 145408, 145408, 1024, 4096, 0x741803fb +0, 146432, 146432, 1024, 4096, 0xf2a7dff9 +0, 147456, 147456, 1024, 4096, 0xbd2ffe0b +0, 148480, 148480, 1024, 4096, 0xed19f9eb +0, 149504, 149504, 1024, 4096, 0xa3c4f4a4 +0, 150528, 150528, 1024, 4096, 0xfac20796 +0, 151552, 151552, 1024, 4096, 0x315cf81e +0, 152576, 152576, 1024, 4096, 0xaf0df76e +0, 153600, 153600, 1024, 4096, 0x6f92e4ca +0, 154624, 154624, 1024, 4096, 0xad32079c +0, 155648, 155648, 1024, 4096, 0xcd03e6e7 +0, 156672, 156672, 1024, 4096, 0xff01f923 +0, 157696, 157696, 1024, 4096, 0xee4d1713 +0, 158720, 158720, 1024, 4096, 0x8db9e3f4 +0, 159744, 159744, 1024, 4096, 0xeef9f20a +0, 160768, 160768, 1024, 4096, 0xa329d900 +0, 161792, 161792, 1024, 4096, 0xf9d0003b +0, 162816, 162816, 1024, 4096, 0x9e42f62c +0, 163840, 163840, 1024, 4096, 0x31f2ee64 +0, 164864, 164864, 1024, 4096, 0x8d340bb6 +0, 165888, 165888, 1024, 4096, 0xd7cbf004 +0, 166912, 166912, 1024, 4096, 0x262105c9 +0, 167936, 167936, 1024, 4096, 0xf3d30dc7 +0, 168960, 168960, 1024, 4096, 0x09adf291 +0, 169984, 169984, 1024, 4096, 0xf2b207e3 +0, 171008, 171008, 1024, 4096, 0x58df0639 +0, 172032, 172032, 1024, 4096, 0x373ad9cd +0, 173056, 173056, 1024, 4096, 0xb0b2fc8b +0, 174080, 174080, 1024, 4096, 0xb72af6b8 +0, 175104, 175104, 1024, 4096, 0xcee1f544 +0, 176128, 176128, 1024, 4096, 0xe88dded4 +0, 177152, 177152, 1024, 4096, 0xc606e4d4 +0, 178176, 178176, 1024, 4096, 0x6220006d +0, 179200, 179200, 1024, 4096, 0xde870592 +0, 180224, 180224, 1024, 4096, 0xb5a6eaaf +0, 181248, 181248, 1024, 4096, 0xe4eaf266 +0, 182272, 182272, 1024, 4096, 0xdb55f225 +0, 183296, 183296, 1024, 4096, 0x40550828 +0, 184320, 184320, 1024, 4096, 0x3f80fabd +0, 185344, 185344, 1024, 4096, 0xe9c8eb8d +0, 186368, 186368, 1024, 4096, 0xd25fe663 +0, 187392, 187392, 1024, 4096, 0x41720adb +0, 188416, 188416, 1024, 4096, 0x5fd1fc96 +0, 189440, 189440, 1024, 4096, 0x007cf9ec +0, 190464, 190464, 1024, 4096, 0xeab3efe0 +0, 191488, 191488, 1024, 4096, 0xcb75ee4c +0, 192512, 192512, 1024, 4096, 0xd866f6c1 +0, 193536, 193536, 1024, 4096, 0xe0c4f911 +0, 194560, 194560, 1024, 4096, 0x7268e790 +0, 195584, 195584, 1024, 4096, 0x6258ee4a +0, 196608, 196608, 1024, 4096, 0x880b003a +0, 197632, 197632, 1024, 4096, 0x117bfd71 +0, 198656, 198656, 1024, 4096, 0x1b7900c7 +0, 199680, 199680, 1024, 4096, 0xcf3fe8b5 +0, 200704, 200704, 1024, 4096, 0x9de2f010 +0, 201728, 201728, 1024, 4096, 0xe6b4ff4a +0, 202752, 202752, 1024, 4096, 0x37420c72 +0, 203776, 203776, 1024, 4096, 0x0560e821 +0, 204800, 204800, 1024, 4096, 0xd676f037 +0, 205824, 205824, 1024, 4096, 0xe141f3e1 +0, 206848, 206848, 1024, 4096, 0x8af10210 +0, 207872, 207872, 1024, 4096, 0x30c5fb99 +0, 208896, 208896, 1024, 4096, 0x39cdf501 +0, 209920, 209920, 1024, 4096, 0x8e37f69d +0, 210944, 210944, 1024, 4096, 0x6220006d +0, 211968, 211968, 1024, 4096, 0xde870592 +0, 212992, 212992, 1024, 4096, 0xb5a6eaaf +0, 214016, 214016, 1024, 4096, 0xe4eaf266 +0, 215040, 215040, 1024, 4096, 0xdb55f225 +0, 216064, 216064, 1024, 4096, 0x40550828 +0, 217088, 217088, 1024, 4096, 0x3f80fabd +0, 218112, 218112, 1024, 4096, 0xe9c8eb8d +0, 219136, 219136, 1024, 4096, 0xd25fe663 +0, 220160, 220160, 1024, 4096, 0x41720adb +0, 221184, 221184, 1024, 4096, 0x5fd1fc96 +0, 222208, 222208, 1024, 4096, 0x007cf9ec +0, 223232, 223232, 1024, 4096, 0xeab3efe0 +0, 224256, 224256, 1024, 4096, 0xcb75ee4c +0, 225280, 225280, 1024, 4096, 0xd866f6c1 +0, 226304, 226304, 1024, 4096, 0xe0c4f911 +0, 227328, 227328, 1024, 4096, 0x7268e790 +0, 228352, 228352, 1024, 4096, 0x6258ee4a +0, 229376, 229376, 1024, 4096, 0x880b003a +0, 230400, 230400, 1024, 4096, 0x117bfd71 +0, 231424, 231424, 1024, 4096, 0x1b7900c7 +0, 232448, 232448, 1024, 4096, 0xcf3fe8b5 +0, 233472, 233472, 1024, 4096, 0x9de2f010 +0, 234496, 234496, 1024, 4096, 0xe6b4ff4a +0, 235520, 235520, 1024, 4096, 0x37420c72 +0, 236544, 236544, 1024, 4096, 0x0560e821 +0, 237568, 237568, 1024, 4096, 0xd676f037 +0, 238592, 238592, 1024, 4096, 0xe141f3e1 +0, 239616, 239616, 1024, 4096, 0x8af10210 +0, 240640, 240640, 1024, 4096, 0x30c5fb99 +0, 241664, 241664, 1024, 4096, 0x39cdf501 +0, 242688, 242688, 1024, 4096, 0x8e37f69d +0, 243712, 243712, 1024, 4096, 0x6220006d +0, 244736, 244736, 1024, 4096, 0xde870592 +0, 245760, 245760, 1024, 4096, 0xb5a6eaaf +0, 246784, 246784, 1024, 4096, 0xe4eaf266 +0, 247808, 247808, 1024, 4096, 0xdb55f225 +0, 248832, 248832, 1024, 4096, 0x40550828 +0, 249856, 249856, 1024, 4096, 0x3f80fabd +0, 250880, 250880, 1024, 4096, 0xe9c8eb8d +0, 251904, 251904, 1024, 4096, 0xd25fe663 +0, 252928, 252928, 1024, 4096, 0x41720adb +0, 253952, 253952, 1024, 4096, 0x5fd1fc96 +0, 254976, 254976, 1024, 4096, 0x007cf9ec +0, 256000, 256000, 1024, 4096, 0xeab3efe0 +0, 257024, 257024, 1024, 4096, 0xcb75ee4c +0, 258048, 258048, 1024, 4096, 0xd866f6c1 +0, 259072, 259072, 1024, 4096, 0xe0c4f911 +0, 260096, 260096, 1024, 4096, 0x7268e790 +0, 261120, 261120, 1024, 4096, 0x6258ee4a +0, 262144, 262144, 1024, 4096, 0x880b003a +0, 263168, 263168, 1024, 4096, 0x117bfd71 +0, 264192, 264192, 408, 1632, 0x495d360a +0, 264600, 264600, 1411, 5644, 0x34920173 -- 1.9.1
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
