On Fri, May 13, 2016 at 12:00:24PM +0200, Hendrik Leppkes wrote: > On Fri, May 13, 2016 at 11:48 AM, foo86 <fooba...@gmail.com> wrote: > > Valid sample_fmt will be set by dcadec_decode_frame() based on stream > > type. > > --- > > libavcodec/dcadec.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c > > index e3a4b0d..565242d 100644 > > --- a/libavcodec/dcadec.c > > +++ b/libavcodec/dcadec.c > > @@ -374,9 +374,6 @@ static av_cold int dcadec_init(AVCodecContext *avctx) > > break; > > } > > > > - avctx->sample_fmt = AV_SAMPLE_FMT_S32P; > > - avctx->bits_per_raw_sample = 24; > > - > > return 0; > > } > > > > Having an initial format for the most "common" types of streams is > generally sensible.
Do you suggest it should be changed to AV_SAMPLE_FMT_FLTP then? Core streams are probably the most "common". I don't have a strong prefenence on this, but I thought that not having initial sample_fmt set will serve as useful indication to API user that sample_fmt can (and will) change after the frame is decoded. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
