Hello All, Monday, April 25, 2016, 6:50:18 PM, you wrote:
HL> On Mon, Apr 25, 2016 at 5:44 PM, Ivan Uskov <ivan.us...@nablet.com> wrote: >> Hello Derek, >> >> Monday, April 25, 2016, 4:50:28 PM, you wrote: >> >> DB> On 4/25/2016 2:14 PM, Ivan Uskov wrote: >>>> The attached patch does fixes the issue of frames duplication >>>> when >>>> elementary h.264 stream decodes by qsvdec. >> >> DB> Could you perhaps elaborate in the commit message, and a code comment, on >> DB> why it must be 2? Where does that value come from, etc. >> I do not see a necessity for additional comments because >> AVCodecContext::ticks_per_frame is public API and already enough documented: >> https://ffmpeg.org/doxygen/2.8/structAVCodecContext.html#a5c62b9c1528a272923ea2a4b86dea31a >> HL> Its not about what the field does, but why this is needed here. So HL> please explain why its set here, and only for this case. A have added brief comment to patch and to code, please review the attached patch. -- Best regards, Ivan mailto:ivan.us...@nablet.com
0001-Bug-fixed-wrong-ticks_per_frame.-For-H.264-stream-ti.patch
Description: Binary data
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
