On Wed, Apr 06, 2016 at 02:55:08AM +0530, Jai Luthra wrote: > Hi, > > On Tue, Apr 05, 2016 at 10:31:44PM +0200, Michael Niedermayer wrote: > > > Should I squash the commits and send a single patch instead? > > > > a single patch makes more sense for reviewing > Cool. I've attached the squashed patch for review. > > > > PS: I noticed Disha Singh is also working on this for outreachy. Is it > > > fine if two applicants work on the same project through different > > > programs over the summer? > > > > It is possible AFAIK, but its unlikely we will accept 2 students doing > > exactly the same > > So far noone has passed the qualfication task for this project though > I'll complete it and submit for final evaluation within a week. > Sorry for being late, I was busy with college studies but I'll be completely > free during the coding period. > > Cheers, > Jai Luthra
[...]
> +static ChannelParams restart_channel_params[MAX_CHANNELS];
> +static DecodingParams restart_decoding_params[MAX_SUBSTREAMS];
> +static BestOffset restart_best_offset[NUM_CODEBOOKS] = {{0}};
"non const" statics are not allowed as they break with muliple
encoder instances
that is if they would change, if they do not change they should be
const
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
