On Mon, Mar 28, 2016 at 06:09:03PM +0200, Clément Bœsch wrote: > On Mon, Mar 28, 2016 at 04:57:51PM +0200, Michael Niedermayer wrote: > > On Mon, Mar 28, 2016 at 02:10:51PM +0200, Clément Bœsch wrote: > > > lavc/utils already rescales avpkt->pts to sub->pts in AV_TIME_BASE_Q > > > before calling the decode callback. This prevents from rescaling again > > > into the decoder, and avoid the use of avctx->time_base which will > > > disappear in the incoming codecpar merge. > > > > > > This commit also replaces the use of "20 centisecond" (ass time base) > > > with "200 ms". > > > --- > > > libavcodec/ccaption_dec.c | 14 +++++++------- > > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > with > > ./ffmpeg -f lavfi -i "movie=Starship_Troopers.vob[out0+subcc]" -vn -map s > > out.srt > > > > this causes a moderate change in the timings > > is that intended ? > > > > Nope, that was a bug, thanks for noticing. It appears FATE isn't enough...
yes, a fate test should be added for this, the file used here is a bit big though, maybe someone can come up with a smaller testcase ... > New patch attached. [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
