Hi, On Sat, Mar 26, 2016 at 10:04 AM, Thomas Mundt < loudmax-at-yahoo...@ffmpeg.org> wrote:
> >>>Kieran Kunhya <kier...@obe.tv> schrieb am Sa, 26.3.2016: > >> On Fri, 25 Mar 2016 at 22:32 Thomas Mundt <loudmax-at-yahoo.de at > ffmpeg.org> wrote: > > > >> Signed-off-by: Thomas Mundt <loudmax at yahoo.de> > >> --- > >> libavfilter/vf_colormatrix.c | 182 > >> ++++++++++++++++++++++++++++++++++++++++++- > >> > > > > These functions are basically the same, have you considered factoring the > > code out? > > > > Kieran > > I thought keeping it seperate would be easier to review. > But I can do that. Maybe as a subsequent patch? I think he means templating out typelessly like h264/hevc/vp9 do. I agree that would probably be nicer. Binary size is same but less duplicated code. Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
