Hi! Attached patch fixes the default display window for cropped hevc and pix_fmt != yuv420. Tested with x265 --crop-rect and FFmpeg -apply_defdispwin.
Please review, Carl Eugen
diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index a36c6ee..ce3f3df 100644 --- a/libavcodec/hevc_ps.c +++ b/libavcodec/hevc_ps.c @@ -596,11 +596,12 @@ static void decode_vui(GetBitContext *gb, AVCodecContext *avctx, memcpy(&backup, gb, sizeof(backup)); if (vui->default_display_window_flag) { - //TODO: * 2 is only valid for 420 - vui->def_disp_win.left_offset = get_ue_golomb_long(gb) * 2; - vui->def_disp_win.right_offset = get_ue_golomb_long(gb) * 2; - vui->def_disp_win.top_offset = get_ue_golomb_long(gb) * 2; - vui->def_disp_win.bottom_offset = get_ue_golomb_long(gb) * 2; + int vert_mult = 1 + (sps->chroma_format_idc < 2); + int horiz_mult = 1 + (sps->chroma_format_idc < 3); + vui->def_disp_win.left_offset = get_ue_golomb_long(gb) * horiz_mult; + vui->def_disp_win.right_offset = get_ue_golomb_long(gb) * horiz_mult; + vui->def_disp_win.top_offset = get_ue_golomb_long(gb) * vert_mult; + vui->def_disp_win.bottom_offset = get_ue_golomb_long(gb) * vert_mult; if (apply_defdispwin && avctx->flags2 & AV_CODEC_FLAG2_IGNORE_CROP) {
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel