Re: [FFmpeg-devel] [PATCHv3 1/3] tests/gapless: add gapless aac tests

[Michael Niedermayer]

On Sat, Mar 12, 2016 at 02:49:10AM +0100, Marton Balint wrote:
> Signed-off-by: Marton Balint <c...@passwd.hu>
> ---
>  tests/fate-run.sh                 | 30 ++++++++++++++
>  tests/fate/gapless.mak            | 20 +++++++++-
>  tests/ref/fate/gapless2-ipod-aac1 | 82 
> +++++++++++++++++++++++++++++++++++++++
>  tests/ref/fate/gapless2-ipod-aac2 | 82 
> +++++++++++++++++++++++++++++++++++++++
>  tests/ref/fate/gapless2-mov-aac   | 82 
> +++++++++++++++++++++++++++++++++++++++
>  5 files changed, 295 insertions(+), 1 deletion(-)
>  create mode 100644 tests/ref/fate/gapless2-ipod-aac1
>  create mode 100644 tests/ref/fate/gapless2-ipod-aac2
>  create mode 100644 tests/ref/fate/gapless2-mov-aac
> 
> diff --git a/tests/fate-run.sh b/tests/fate-run.sh
> index 16087cb..1063c0c 100755
> --- a/tests/fate-run.sh
> +++ b/tests/fate-run.sh
> @@ -96,6 +96,21 @@ probeframes(){
>      run ffprobe${PROGSUF} -show_frames -v 0 "$@"
>  }
>  
> +probegaplessinfo(){
> +    filename=$1
> +    shift
> +    run ffprobe${PROGSUF} -bitexact -select_streams a -show_entries 
> format=start_time,duration:stream=index,start_pts,duration_ts -v 0 
> "$filename" "$@"
> +    pktfile1="${filename}.pkts"
> +    framefile1="${filename}.frames"
> +    cleanfiles="$cleanfiles $pktfile1 $framefile1"
> +    run ffprobe${PROGSUF} -bitexact -select_streams a -of compact 
> -show_entries packet=pts,dts,duration -v 0 "$filename" "$@" | nl -w 1 -s '|' 
> > $pktfile1
> +    head -n 8 $pktfile1
> +    tail -n 8 $pktfile1
> +    run ffprobe${PROGSUF} -bitexact -select_streams a -of compact 
> -show_entries 
> frame=pkt_pts,pkt_dts,best_effort_timestamp,pkt_duration,nb_samples -v 0 
> "$filename" "$@" | nl -w 1 -s '|' > $framefile1
> +    head -n 8 $framefile1
> +    tail -n 8 $framefile1
> +}
> +
>  ffmpeg(){
>      dec_opts="-hwaccel $hwaccel -threads $threads -thread_type $thread_type"
>      ffmpeg_args="-nostdin -nostats -cpuflags $cpuflags"
> @@ -249,6 +264,21 @@ gapless(){
>      do_md5sum $decfile3
>  }
>  
> +gapless2(){
> +    sample=$(target_path $1)
> +    format=$2
> +    codec=$3
> +
> +    file1="${outdir}/${test}.out-1"
> +    cleanfiles="$cleanfiles $file1"
> +
> +    # test source data
> +    probegaplessinfo "$sample" | sed 's/^/source|/'
> +    # test data after reencoding
> +    ffmpeg -i "$sample" -flags +bitexact -fflags +bitexact -map 0:a -c:a 
> $codec -f $format -y $file1
> +    probegaplessinfo "$file1" | sed 's/^/target|/'
> +}
> +
>  concat(){
>      template=$1
>      sample=$2
> diff --git a/tests/fate/gapless.mak b/tests/fate/gapless.mak
> index 2fb005f..8d819bd 100644
> --- a/tests/fate/gapless.mak
> +++ b/tests/fate/gapless.mak
> @@ -3,5 +3,23 @@ fate-gapless-mp3: CMD = gapless 
> $(TARGET_SAMPLES)/gapless/gapless.mp3
>  
>  FATE_GAPLESS = $(FATE_GAPLESS-yes)
>  
> +FATE_GAPLESS2_PROBE-$(call ENCDEC, AAC, MOV) += fate-gapless2-ipod-aac1
> +fate-gapless2-ipod-aac1: ffprobe$(PROGSSUF)$(EXESUF)
> +fate-gapless2-ipod-aac1: CMD = gapless2 
> $(TARGET_SAMPLES)/cover_art/Owner-iTunes_9.0.3.15.m4a ipod aac

i missed that but
is this writing into the fate samples directory ?
thats not good if it does, the directory may be read only and would
not get cleaned

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates

signature.asc
Description: Digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel