Hi

see the 2 attached patches
ISP still has probems with git send email here

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
From a8b2a1a51c8f570f496d53e3295d5ebf330d9fcc Mon Sep 17 00:00:00 2001
From: Michael Niedermayer <mich...@niedermayer.cc>
Date: Sat, 5 Mar 2016 13:29:16 +0100
Subject: [PATCH 1/2] avcodec: try to document timebase a bit more

Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc>
---
 libavcodec/avcodec.h |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 5dc4b73..981ceb7 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -1669,7 +1669,15 @@ typedef struct AVCodecContext {
      * timebase should be 1/framerate and timestamp increments should be
      * identically 1.
      * This often, but not always is the inverse of the frame rate or field rate
-     * for video.
+     * for video. 1/time_base is not the average frame rate if the frame rate is not
+     * constant.
+     *
+     * Like containers, elementary streams also can store timestamps, 1/time_base
+     * is the unit in which these timestamps are specified.
+     * As example of such codec time base see ISO/IEC 14496-2:2001(E)
+     * vop_time_increment_resolution and fixed_vop_rate
+     * (fixed_vop_rate == 0 implies that it is different from the framerate)
+     *
      * - encoding: MUST be set by user.
      * - decoding: the use of this field for decoding is deprecated.
      *             Use framerate instead.
-- 
1.7.9.5

From 97f37e16d295546bb877f2948773fdee728c95fe Mon Sep 17 00:00:00 2001
From: Michael Niedermayer <mich...@niedermayer.cc>
Date: Sat, 5 Mar 2016 13:37:44 +0100
Subject: [PATCH 2/2] avcodec/avcodec: try to document some issues with
 framerate

Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc>
---
 libavcodec/avcodec.h |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 981ceb7..4973925 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -3226,6 +3226,13 @@ typedef struct AVCodecContext {
     int initial_padding;
 
     /**
+     *
+     * Note, for variable framerate material this has undefined meaning currently
+     * and is not set to the actual framerate nor {0,1} but can be set to
+     * 1/timebase (FIXME) the code in some parts assumes framerate == 1/timebase
+     * which is generally not true but these parts need to be fixed before framerate
+     * can be fixed.
+     *
      * - decoding: For codecs that store a framerate value in the compressed
      *             bitstream, the decoder may export it here. { 0, 1} when
      *             unknown.
-- 
1.7.9.5

Attachment: signature.asc
Description: Digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to