Now with ffmpeg-devel in CC
On Fri, Mar 04, 2016 at 04:37:41PM +0100, Clément Bœsch wrote:
> On Fri, Mar 04, 2016 at 04:22:44PM +0100, Michael Niedermayer wrote:
> > On Fri, Feb 26, 2016 at 10:01:51PM +0100, Clément Bœsch wrote:
> > > ffmpeg | branch: master | Clément Bœsch <u...@pkh.me> | Wed Jan 6
> > > 13:43:23 2016 +0100| [29412821241050c846dbceaad4b9752857659977] |
> > > committer: Clément Bœsch
> > [...]
> > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > > index 7a56899..d3e035a 100644
> > > --- a/libavcodec/avcodec.h
> > > +++ b/libavcodec/avcodec.h
> > > @@ -3285,6 +3285,10 @@ typedef struct AVCodecContext {
> > > #define FF_SUB_CHARENC_MODE_AUTOMATIC 0 ///< libavcodec will select
> > > the mode itself
> > > #define FF_SUB_CHARENC_MODE_PRE_DECODER 1 ///< the AVPacket data needs
> > > to be recoded to UTF-8 before being fed to the decoder, requires iconv
> > >
> > > + int sub_text_format;
> > > +#define FF_SUB_TEXT_FMT_ASS 0
> > > +#define FF_SUB_TEXT_FMT_ASS_WITH_TIMINGS 1
> > > +
> > > /**
> > > * Skip processing alpha if supported by codec.
> > > * Note that if the format uses pre-multiplied alpha (common with
> > > VP6,
> >
> > doesnt this break ABI ?
> >
>
> Ah, mmmh... We're not that far away from the bottom, aren't all the
> following fields supposed to be accessed through AVoption or other
> accessors?
> > How to proceed here, should I just move it at the bottom of the struct > since it was introduced recently? moving it after all fields which can be directly accessed probably unless i miss something (fields not in 3.0 could be ignored as we just have to restore compatibility with 3.0) i suspect thats more or less the same as "move it at the bottom " [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Breaking DRM is a little like attempting to break through a door even though the window is wide open and the only thing in the house is a bunch of things you dont want and which you would get tomorrow for free anyway
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
