On 11.02.2016 15:00, Paul B Mahol wrote:
On 2/11/16, Tobias Rapp <t.r...@noa-archive.com> wrote:
On 11.02.2016 14:12, Paul B Mahol wrote:
On 2/11/16, Tobias Rapp <t.r...@noa-archive.com> wrote:
Signed-off-by: Tobias Rapp <t.r...@noa-archive.com>
---
   libavfilter/f_metadata.c | 16 ++++++++--------
   1 file changed, 8 insertions(+), 8 deletions(-)


Patches LGTM.

Removed tabs from patches, gonna apply it soon.

Sorry for the tabs, I forgot to add "set expandtab" in .vimrc on my machine.

I guess after patch #2 the "string" function can be reduced to check for
full string match only and doesn't need "length" anymore? If you agree
what about renaming "string" to "same_str"?

OK, will do it.

I didn't intend to assign the patch writing task to you, just wanted to know your opinion.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to