On Wed, Feb 03, 2016 at 05:49:56PM +0100, Vittorio Giovara wrote: > ffmpeg | branch: master | Vittorio Giovara <vittorio.giov...@gmail.com> | Mon > Nov 9 03:15:06 2015 +0100| [2862b63783b5556f7f3fb2d097629bc6879f833a] | > committer: Vittorio Giovara > > lavc: Move prediction_method to codec private options > > This options is only used by huffyuv, ffvhuv, jpegls, mjpeg, > mpegvideoenc, png, utvideo. > It is a very codec-specific options, so deprecate the global variant. > Set proper limits to the maximum allowed values, and update utvideoenc > tests to use the new option name. > > Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=2862b63783b5556f7f3fb2d097629bc6879f833a [...]
> @@ -631,12 +638,32 @@ FF_ENABLE_DEPRECATION_WARNINGS
> return 0;
> }
>
> +#define OFFSET(x) offsetof(UtvideoContext, x)
> +#define VE AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM
> +static const AVOption options[] = {
> +{ "pred", "Prediction method", OFFSET(frame_pred), AV_OPT_TYPE_INT, { .i64 =
> PRED_LEFT }, PRED_NONE, PRED_MEDIAN, VE, "pred" },
> + { "none", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = PRED_NONE }, INT_MIN,
> INT_MAX, VE, "pred" },
> + { "left", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = PRED_LEFT }, INT_MIN,
> INT_MAX, VE, "pred" },
> + { "gradient", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = PRED_GRADIENT },
> INT_MIN, INT_MAX, VE, "pred" },
> + { "median", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = PRED_MEDIAN },
> INT_MIN, INT_MAX, VE, "pred" },
> +
> + { NULL},
> +};
this breaks existing command line usage like -pred 3
and "3" previously lacked a named constant so people had to use a
litteral 3 i think
this change should be documented if its left that way
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
