Hi Nico, On Mon, Feb 1, 2016 at 3:23 PM, Nico Weber <tha...@chromium.org> wrote:
> Hi, > > After http://llvm.org/viewvc/llvm-project?view=revision&revision=259271, > clang complains: > > fmpeg\libavcodec/vp3data.h(61,34) : error: implicit > conversion from 'int' to 'int8_t' (aka 'signed char') changes value > from > 128 to -128 [-Werror,-Wconstant-conversion] > 32, 40, 48, 64, 64, 64, 96, 128, > ^~~ > > That array is explicitly int8_t, so it seems this is supposed to be signed > data -- storing 128 in it looks a bit surprising. Is this intentional? > Should we disable this warning for ffmpeg when building it as part of > Chromium, or is this something you want to fix upstream? Should fix upstream. All values are copied into base_matrix, which is of type uint8_t, so I think it's safe to change the type of all inter/intra default quantizer tables to uint8_t also. Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
