On 02/01/2016 08:02 AM, Mats Peterson wrote:
Should be "1 bpp video in AVI", not just "1 bpp video".
Your patch that switches to monow when a 1 bpp AVI doesn't contain a
palette is rather kludgy and redundant to me. And users will undoubtly
be surprised by the use of monow for the unique case of 1 bpp AVI
without a palette, rather than using pal8 consistently for all 1 bpp AVI
files, just like it is done for 2 and 4 bpp. It is also semantically
incorrect to use monow for 1 bpp AVI whatsoever, since there is no such
thing as "monochrome" video data in AVI.
I don't understand what's so important about retaining monow inside
FFmpeg when it comes to AVI, when it's obviously OK to convert 2 and 4
bpp to pal8. Once again, if you want a straight passthrough of 1 bpp AVI
video data, just use "-c:v copy".
Judging by the lack of objections against this patch from people (except
you, Michael) on the mailing list, I take it as a "silent approval".
Mats
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
