On 3 January 2016 at 23:13, Jan Ekstrom <jee...@gmail.com> wrote: > Hi, > > In general looks good, although it might look a bit weird for someone > as usually libraries have initialization functions called like that. > That said, this is what > > https://gnupg.org/documentation/manuals/gcrypt/Initializing-the-library.html > recommends. > > My only comment would be that we might want to set the parameter to > GCRYPT_VERSION instead of NULL, as we most probably care if the > library loaded matches our version (unless these versions change even > if API doesn't change). >
This is where it shows my ignorance but I don't know which of these is the best way of dealing with that. I tested all three and they all work with the linked sample.
0001-rtmpdh-Initialize-gcrypt-before-using-it-v1.patch
Description: Binary data
0001-rtmpdh-Initialize-gcrypt-before-using-it-v2.patch
Description: Binary data
0001-rtmpdh-Initialize-gcrypt-before-using-it-v3.patch
Description: Binary data
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
