On 12/23/2015 05:26 PM, Mats Peterson wrote:
On 12/23/2015 05:24 PM, Mats Peterson wrote:
On 12/23/2015 05:17 PM, Alexander Strasser wrote:
On 2015-12-23 13:33 +0100, Hendrik Leppkes wrote:
Am 23.12.2015 13:28 schrieb "Mats Peterson" <
matsp888-at-yahoo....@ffmpeg.org>:

On 12/23/2015 01:15 PM, Mats Peterson wrote:

On 12/23/2015 01:13 PM, Carl Eugen Hoyos wrote:

Mats Peterson <matsp888-at-yahoo.com <at> ffmpeg.org> writes:

In matroskadec.c, I'm also putting the palette in 'extradata',
like it's done for V_MS/VFW/FOURCC; this is a requirement in
order for MPlayer to recognize the palette.


This is wrong, please remove this hunk.


The reason for this is because MPlayer won't notice the
palette otherwise, as I said before.


This is not correct.

Try it yourself.


Please do.

Carl Eugen

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Stop this meaningless rant until you've tried it. I know more about
this
issue than you do.

Mats


Let me once and for all clarify the issue with MPlayer and the palette
for you, Eugen. The palette side data packet is sent alright in
matroskadec.c, the problem is that MPlayer sends ANOTHER palette side
data
AFTERWARDS, using whatever is in extradata as the palette. Complain
at the
authors of MPlayer, not me.


If anything it sounds like a bug in mplayer, not FFmpeg.

   I may be totally of the mark, but wasn't it fixed in MPlayer with
r37563:

   Date:   Sat Dec 12 17:34:35 2015 +0000

     mpcodecs/vd_ffmpeg: Do not overwrite palette with random extradata.


   If yes, I think we have some miscommunication going on here.


   Alexander
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


That's totally unrelated.

Mats


In matroskadec.c, a palette side data packet wasn't added whatsoever
until I patched it.

Mats


The best way to understand what this issue is about is to try the sample files, with and without the patch.

https://drive.google.com/open?id=0B3_pEBoLs0faWElmM2FnLTZYNlk

Mats

--
Mats Peterson
http://matsp888.no-ip.org/~mats/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to