On 12/21/2015 07:02 PM, Ganesh Ajjanagadde wrote:
On Mon, Dec 21, 2015 at 9:49 AM, Mats Peterson
<matsp888-at-yahoo....@ffmpeg.org> wrote:
On 12/21/2015 06:04 PM, Mats Peterson wrote:

Alright then, let's see how this turns out:


Perhaps I should once again explain the issue:

Palettized QuickTime video in Matroska has hitherto not been recognized
whatsoever, and the "palette" used has been completely random.

The patch for matroskadec.c fixes this issue by adding a palette side data
packet in matroska_deliver_packet(), much in the same way as it's done in
mov.c.

The change to mov.c consists mainly of moving the palette handling from the
mov_parse_stsd_video() function to a new get_qtpalette() function in the new
file qtpalette.c, which is shared by both matroskadec.c and mov.c.

In matroskadec.c, I'm also putting the palette in 'extradata', like it's
done for V_MS/VFW/FOURCC; this is a requirement in order for MPlayer to
recognize the palette.

Please add such things to the commit message, i.e while doing git
commit, it fires up your editor. Write the rationale in the same place
you wrote: "Alright then, let's see how this turns out:".


Mats

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Good to know for the future. Thanks.

Mats

--
Mats Peterson
http://matsp888.no-ip.org/~mats/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to