I'm not very versed at (or planning to become) using Git and its utilites, that's why I provide a patch here for you to examine. I hope this approach is accepted. And although it's about two different issues, they are both concerning the same file, i.e. matroskadec.c. Mats -- Mats Peterson http://matsp888.no-ip.org/~mats/ From: Michael Niedermayer <michae...@gmx.at> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Sent: Friday, December 11, 2015 1:30 AM Subject: Re: [FFmpeg-devel] [PATCH] Make FFmpeg recognize QT version 0 sound sample descriptions and store the palette in matroskadec.c On Thu, Dec 10, 2015 at 11:06:58AM +0000, Mats Peterson wrote:
> I've attached a unified diff of the latest Git version of matroskadec.c that > does two things: > 1. It allows FFmpeg to recognize QuickTime version 0 sound sample > descriptions by using 36 instead of 86 as the minimum private data size for > A_QUICKTIME. > 2. The palette, in QuickTime video that has one, is put in extradata, to make > MPlayer recognize it and tack it to the end of its "fake" BITMAPINFOHEADER. > This patch is an improvement and tidying-up of a proposed patch by Martin > Storsjö, for the record. The version 0 sound sample description stuff is made > by me long ago, though. > > Comments welcome. This sounds like 2 independant changes each independant change should be in its own patch and commit. you can easily split changes into commits with git add -p and git commit this also produces git compatible patches with commit messages (with git format-patch or git send-email) [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to cater to the crowd; for what I know they do not approve, and what they approve I do not know. -- Epicurus _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
