On Thu, Dec 10, 2015 at 11:20 AM, Ivan Uskov <ivan.us...@nablet.com> wrote: > Hello Hendrik, > > Thursday, December 10, 2015, 1:10:59 PM, you wrote: > >>>>> This patch expose 3 QSV functions as public. >>>>> This is needed because the VPP needs access to these functions too. >>>>> >>>>> Please review. >>>>> >>> >>> HL> public API is not allowed to use config.h, it needs to be config and >>> HL> OS agnostic. >>> Any qsv_* function can not be public since are all under CONFIG_QSV, >>> correct? >>> > > HL> Thats not necessarily true, if its supposed to be public API, it just > HL> has to always be present, so it would have to be changed to just do > HL> nothing and return an error if QSV is not enabled, but the functions > HL> still exist. > But it is exactly that Sven did, there are dummies for all public function > into the qsv_api.c for the case if CONFIG_QSV==0 > What is wrong then?
The public qsv.h uses config.h, thats not allowed. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
