On Tue, Dec 8, 2015 at 11:46 AM, Lvqier <lvq...@gmail.com> wrote:
> On 12/8/15 6:26 PM, Hendrik Leppkes wrote:
>>
>> On Tue, Dec 8, 2015 at 11:19 AM, Lvqier <lvq...@gmail.com> wrote:
>>>
>>> Hi Hendrik,
>>>
>>> The attached is another patch which uses av_reallocp to fix this
>>> issue.
>>>
>> Thanks, that looks almost good. But you should check for a negative
>> return value, as all errors are negative.
>
> Do you mean that the set_segment_filename function should return the value
> which returns from av_reallocp instead of AVERROR(ENOMEM) when it fails?
That would be an option too, but right now you just do
if(av_reallop(..)), at the least this should be if (av_reallocp(...) <
0)
or even better:
ret = av_reallocp(...);
if (ret < 0)
return ret;
- Hendrik
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
