Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: use constants for rc_strategy

[Michael Niedermayer]

On Sat, Nov 21, 2015 at 09:28:31PM +0100, Clément Bœsch wrote:
> ---
>  libavcodec/mpegvideo.h   | 10 +++++++++-
>  libavcodec/ratecontrol.c | 10 +++++++---
>  2 files changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h
> index df1a13f..271ef5e 100644
> --- a/libavcodec/mpegvideo.h
> +++ b/libavcodec/mpegvideo.h
> @@ -557,6 +557,12 @@ typedef struct MpegEncContext {
>  #define FF_MPV_FLAG_NAQ          0x0010
>  #define FF_MPV_FLAG_MV0          0x0020
>  
> +enum rc_strategy {
> +    MPV_RC_STRATEGY_FFMPEG,
> +    MPV_RC_STRATEGY_XVID,
> +    NB_MPV_RC_STRATEGY

maybe the values should be hardcoded here as in
MPV_RC_STRATEGY_FFMPEG = ...

otherwise LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope

signature.asc
Description: Digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel