Hi, On Fri, Nov 20, 2015 at 11:39 AM, Ganesh Ajjanagadde <gajja...@mit.edu> wrote:
> [...] > On Fri, Nov 20, 2015 at 9:30 AM, Ronald S. Bultje <rsbul...@gmail.com> > wrote: > > He pointed out that you added multiple instances of the exact same line > in > > the code: > > > > av_log(s, AV_LOG_WARNING, "ffio_ensure_seekback(): %s\n", > av_err2str(ret)); > > > > which is both duplicate as well as meaningless. There is nothing to > disagree > > with here, his criticism is just and needs to be addressed. Stop being > > defensive about trivial things like that. Patch review is all about > finding > > issues, fixing them, and moving on. > > > > Ronald > > To get things straight, are you unhappy about repetition of the same > message, or unhappy about the choice of message but fine with the > repetition per se? > If it is the former, we will need an mp3 person to suggest what > message to use for the two failures, and you may want to look at your > own avcodec/vp9:4194. > > If it is the latter, I have an idea. > Both, to some extend, but I guess if you improve the message to explain what went wrong, the other isn't an issue anymore. So I would suggest to improve the message and that's sufficient for me. Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
