On Sun, Nov 1, 2015 at 5:46 PM, Nicolas George <geo...@nsup.org> wrote: > Le primidi 11 brumaire, an CCXXIV, Michael Niedermayer a écrit : >> less fragile could be ret < 0 && ret != the error code generated by NaN >> i dont know what to do about the clutter or if this approuch makes >> sense or if just droping the return warning for av_expr_parse_and_eval >> would be better ... > > The current code does not crash when errors happens (and ENOMEM doest not > happen for this kind of small allocation anyway), my advice is that it is > better left as is.
Can't users give arbitrarily long arithmetic expressions? The expressions seem to me to be essentially untrusted data. I agree in normal usage, strings are small. I won't press this further if it is still a nack due to your point about the lack of e.g dereferencing here, or in general usage of av_expr_parse_and_eval. Thanks all for reviews. > > Regards, > > -- > Nicolas George > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
