On Mon, 26 Oct 2015 20:31:00 +0100 Michael Niedermayer <mich...@niedermayer.cc> wrote:
> On Sun, Oct 25, 2015 at 06:31:02PM +0100, wm4 wrote: > > Channel layouts are essentially uint64_t, and every value is valid. > > --- > > libswresample/options.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > this LGTM if no unsiged int64 support is added to avoptions When I wanted to give a try, I noticed that the min/max fields are double, and that double doesn't have enough mantissa bits to cover the full range. So adding a uint64 type for this purpose would be just as broken. I'm wonder whether setting min/max to -inf/inf would make sense. In a way it'd be better than INT64_MAX (which is a lie, because after rounding it's INT64_MAX+1), but in the end it's the same thing. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
