Re: [FFmpeg-devel] [PATCH 2/5] ffmpeg: exit on av_write_trailer failure if exit_on_error is set

[Michael Niedermayer]

On Sun, Oct 18, 2015 at 12:38:51AM +0200, Michael Niedermayer wrote:
> On Sun, Oct 18, 2015 at 12:24:04AM +0200, Marton Balint wrote:
> > Signed-off-by: Marton Balint <c...@passwd.hu>
> > ---
> >  ffmpeg.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/ffmpeg.c b/ffmpeg.c
> > index 95f7e2f..94dfb04 100644
> > --- a/ffmpeg.c
> > +++ b/ffmpeg.c
> > @@ -4106,6 +4106,8 @@ static int transcode(void)
> >          os = output_files[i]->ctx;
> >          if ((ret = av_write_trailer(os)) < 0) {
> >              av_log(NULL, AV_LOG_ERROR, "Error writing trailer: %s", 
> > av_err2str(ret));
> > +            if (exit_on_error)
> > +                exit_program(1);
> 
> i wonder if ffmpeg should attempt to write all files trailers before
> exiting

either way this LGTM

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire

signature.asc
Description: Digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel