On 10/14/2015 2:16 PM, Ronald S. Bultje wrote: > Hi, > > On Wed, Oct 14, 2015 at 10:50 AM, Nicolas George <geo...@nsup.org> wrote: > >> Le duodi 22 vendémiaire, an CCXXIV, James Almer a écrit : >>> Since these two were never installed, we can remove the >> FF_API_CRYPTO_CONTEXT >>> wrapper from them before applying this patch, as this would be the first >> time >>> the API becomes public. >>> >>> Now, what i want to know is what will it be in the end for the actual >>> deprecation in question? Reimar and Nicolas were against making the >> context >>> opaque as having them in stack has its uses. >>> I want to know what people want, since the deprecation is not present on >> any >>> release and we still have time to rollback. Do we keep the deprecation in >>> place for des, rc4, blowfish and xtea, or remove it altogether? >> >> The reason for my objection are that the odds that the contents of the >> context change in the future are very small for low-level standardized >> crypto functions (this is the reason for making structure opaques). On the >> other hand, foregoing the checks for memory allocations is nice, and crypto >> functions may be used in speed-critical portions of the code where memory >> allocations are not negligible. > > > I think this is a reasonable argument, so +1 from me for "let's expose the > struct and remove deprecations". > > Ronald
Ok, i'll wait a bit in case someone else wants to comment then i'll send a patch undoing the deprecations. Thanks all for your input. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
