On 11.10.2015 20:28, Ronald S. Bultje wrote:
> It's an a non-installed header and only used in one place (flacenc).
^
This 'an' should not be there.
> Since ff_ctz is static inline, it's fine to use that instead.
> ---
> libavcodec/flacenc.c | 2 +-
> libavutil/intmath.c | 5 -----
> libavutil/intmath.h | 8 --------
> 3 files changed, 1 insertion(+), 14 deletions(-)
This breaks libavutil ABI, but that should be OK, because there hasn't been
a release since the SOVERSION bump yet.
Anyway, please also remove the entry for av_ctz from APIchanges.
It's not public API, so it never belonged there.
> diff --git a/libavutil/intmath.h b/libavutil/intmath.h
> index 08d54a6..78db28c 100644
> --- a/libavutil/intmath.h
> +++ b/libavutil/intmath.h
> @@ -159,14 +159,6 @@ static av_always_inline av_const int ff_ctz_c( int v )
> #endif
>
> /**
> - * Trailing zero bit count.
> - *
> - * @param v input value. If v is 0, the result is undefined.
> - * @return the number of trailing 0-bits
> - */
I'm not sure if it's worth the trouble, but maybe this documentation can
be kept. Move it to ff_ctz_c?
Best regards,
Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
