On Thu, Oct 08, 2015 at 03:07:35PM -0500, Rodger Combs wrote:
> ---
> libavcodec/avcodec.h | 1 +
> libavcodec/bitstream_filter.c | 5 +++--
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index ff70d25..ce42e57 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -5026,6 +5026,7 @@ typedef struct AVBitStreamFilterContext {
> struct AVBitStreamFilter *filter;
> AVCodecParserContext *parser;
> struct AVBitStreamFilterContext *next;
> + char *args;as avcodec.h is a public header, this field should be documented minimally the documentation should list if the lib user is allowed to read/write it except that the patch LGTM [,..] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
