On Fri, Oct 02, 2015 at 12:36:54PM +0200, Clément Bœsch wrote: > On Fri, Oct 02, 2015 at 12:20:10PM +0200, wm4 wrote: > > On Fri, 2 Oct 2015 11:23:59 +0200 > > Clément Bœsch <u...@pkh.me> wrote: > > > > > On Fri, Oct 02, 2015 at 11:11:37AM +0200, wm4 wrote: > > > [...] > > > > > +#if HAVE_UTGETOSTYPEFROMSTRING > > > > > vdactx->cv_pix_fmt_type = > > > > > UTGetOSTypeFromString(pixfmt_str); > > > > > +#else > > > > > + av_log(s, loglevel, "UTGetOSTypeFromString() is not > > > > > available " > > > > > + "on this platform, %s pixel format can not be > > > > > honored from " > > > > > + "the command line\n", videotoolbox_pixfmt); > > > > > +#endif > > > > > ret = av_vda_default_init2(s, vdactx); > > > > > CFRelease(pixfmt_str); > > > > > } > > > > > > > > I'd question the use of this in the first place. What does it do at > > > > all? I couldn't find documentation for this option at all. > > > > > > > > You could just do a numerical conversion from FourCC or a plain numeric > > > > value, but I question why this needs to be user-settable at all. > > > > > > This is a CLI option to save a software convert by making VT outputs > > > directly in a given pixel format (the NV12 → BGRA can be faster than > > > swscale for instance). > > > > > > So the function is just to map from the vt pixel format string (user > > > specified) to the vt pixel format. > > > > > > What we can do also is to make a mapping from our pixel format strings to > > > the VT pixel formats, which could make more sense. But this is a behaviour > > > change, and I'm just trying to fix the build here. > > > > > > > Why not disable ffmpeg_videotoolbox.c on iOS then? (I don't mind either > > way, but this fix feels slightly wrong. But I don't want to block it.) > > I could do that, but it would require to add that build granularity, and I > would still need to fix the link to the CoreServices. I don't think the > diff will be simpler & shorter.
Applied. -- Clément B.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
