On Thu, Oct 08, 2015 at 12:39:09PM +0200, Christophe Gisquet wrote: > Hi, > > I came across a weird bug in dependency generation: basically, the > SUBDIR is sometimes not added. > > That seems easy to fix once the offending line is found, but my > knowledge in Makefile and git blame does not allow me to see if this > is correct or there's an historical reason. > > Only tested msys2's make, 4.1.90, under Win64, and an out-of-dir build. > > -- > Christophe
> configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > fd6c72165537f63033d863c135c3a41b196d1ade > 0001-build-system-fix-dependency-generation.patch > From 20e5de4203bff2cf9878385ef195ee6cf355e2e1 Mon Sep 17 00:00:00 2001 > From: Christophe Gisquet <christophe.gisq...@gmail.com> > Date: Thu, 8 Oct 2015 12:30:51 +0200 > Subject: [PATCH] build system: fix dependency generation > > When trying to build the binary dct-test under MSYS2/Win64, the > makefile rule does not have the SUBDIR in the target for its > object file. > > Consequently, modifications to various include files (e.g. C ones) > do not trigger a recompilation. > > When tracing the dependency generating, the dependency generation > has this strange content (linebreak inserted): > sed -e "/^#.*/d" -e "s,^[[:space:]]*dct\\.o,libavcodec/dct.o," \ > > libavcodec/dct-test.d > > For some reason, the $(*F) has weird content. It looks simpler to > use $(@F) instead of $(*F)\\.o, although this was tested on one > single version of make. > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) should i apply this ? i cant really say if this is correct or not though whie testing i noticed that rm ffmpeg ffprobe ; ./configure --progs-suffix=abc && make -j12 fate ends with make: *** No rule to make target `ffprobe', needed by `fate-ffprobe_compact'. [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they exist or not or of what sort they may be, because of the obscurity of the subject, and the brevity of human life -- Protagoras
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
