Hi, 2015-10-05 8:44 GMT+02:00 tim nicholson <nichot20-at-yahoo....@ffmpeg.org>: > On 02/10/15 20:00, Christophe Gisquet wrote: >> A series of 0 in a table can be confusing, and the corresponding checks >> strange, so using a macro instead of that magic is more readable. >> --- >> libavcodec/dnxhddata.c | 10 +++++----- >> libavcodec/dnxhddata.h | 3 +++ >> libavcodec/dnxhddec.c | 6 ++++-- >> 3 files changed, 12 insertions(+), 7 deletions(-) >> >> [..] >> +/** Indicate that a CIDEntry value must be read in the bitstream */ >> +#define DNXHD_VARIABLE 0 >> + > > I'm all for more readable, presumably atm its only ever 0 but may change > in the future, in which case some idea of what it represents may be > useful, I am sure the spec has more than one variable ;)
Actually, it's a convenience value, that we put there after noticing new samples. We don't have access to the DNxHR specs, but it seems a "profile" can have differing bitdepths. I haven't yet verified, but the frame header probably allows to distinguish them (DNXHD_VARIABLE applies to the HR version). I have, down the line, things that may need to split the HR versions. -- Christophe _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
