Hi, On Wed, Sep 16, 2015 at 3:14 PM, James Almer <jamr...@gmail.com> wrote:
> On 9/16/2015 10:12 AM, Ronald S. Bultje wrote: > > --- > > libavcodec/x86/Makefile | 3 +- > > libavcodec/x86/vp9dsp_init.c | 73 > +++++++++++++++++--------------------- > > libavcodec/x86/vp9dsp_init.h | 39 ++++++++++++++++++++ > > vp9dsp.h would be more in line with other headers in the x86 folder. > I found that name a little weird because it would suggest the header is related to actual dsp, whereas it really just covers init routines. If you prefer I can still change it. > diff --git a/libavcodec/x86/vp9dsp_init_16bpp.c > b/libavcodec/x86/vp9dsp_init_16bpp.c > > new file mode 100644 > > index 0000000..be70429 > > --- /dev/null > > +++ b/libavcodec/x86/vp9dsp_init_16bpp.c > > @@ -0,0 +1,71 @@ > > +/* > > + * VP9 SIMD optimizations > > + * > > + * Copyright (c) 2013 Ronald S. Bultje <rsbultje gmail com> > > + * > > + * This file is part of FFmpeg. > > + * > > + * FFmpeg is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU Lesser General Public > > + * License as published by the Free Software Foundation; either > > + * version 2.1 of the License, or (at your option) any later version. > > + * > > + * FFmpeg is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * Lesser General Public License for more details. > > + * > > + * You should have received a copy of the GNU Lesser General Public > > + * License along with FFmpeg; if not, write to the Free Software > > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > 02110-1301 USA > > + */ > > + > > +#include "libavutil/attributes.h" > > +#include "libavutil/avassert.h" > > +#include "libavutil/cpu.h" > > +#include "libavutil/mem.h" > Why? You're not using alloc functions or anything similar. > > LOCAL_ALIGNED doesn't work w/o it. > +#include "libavutil/x86/asm.h" > Isn't this header meant for inline asm? Yes, removed. Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
