On 9/15/2015 1:29 PM, Carl Eugen Hoyos wrote: > James Almer <jamrial <at> gmail.com> writes: > >> On 9/12/2015 3:42 PM, Michael Niedermayer wrote: >>> I think theres consense about "abi compatibility" so i >>> would tend to suggest to move forward with that in mind. >> >> In that case we should go ahead and don't bother with the >> AV_HAVE_INCOMPATIBLE_LIBAV_ABI check at all for this change. > > This was my original suggestion but Hendrik overruled me > (which would have been fine if I had been aware...)
If by "overruled" you mean the postponing he did of FF_API_PROBESIZE_32 that was because back then we still were debating about the whole abi issue. We're not anymore, so the AV_HAVE_INCOMPATIBLE_LIBAV_ABI check can be dropped just fine. But as i said probesize and max_analyze_duration should remain at the top of the struct, so direct access is available. > > Patch applied, Carl Eugen > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel