On Tue, Sep 15, 2015 at 1:22 PM, Stefano Sabatini <stefa...@gmail.com> wrote: > On date Tuesday 2015-09-15 12:59:54 -0400, Ganesh Ajjanagadde encoded: >> On Wed, Sep 9, 2015 at 2:30 PM, Ganesh Ajjanagadde >> <gajjanaga...@gmail.com> wrote: >> > Signed-off-by: Ganesh Ajjanagadde <gajjanaga...@gmail.com> >> > --- >> > libavfilter/f_sendcmd.c | 36 ++++++++++++++++++------------------ >> > 1 file changed, 18 insertions(+), 18 deletions(-) > > I'm against these renaming patches, since I see no gain and they decrease > readability ("s" is less meaningful than "sendcmd"). Also the divert > focus from more important things.
I personally do not like them, but considering the gain of possible consistency across libavfilter, I created these patches. In particular, I do not think it is good if e.g code Paul maintains uses 's', other files use a different convention, etc. If you still feel that way about these, I will definitely drop all remaining patches. > -- > FFmpeg = Friendly & Fiendish Merciful Picky Enlightening Game > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel