PR #22820 opened by sanks011 URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22820 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22820.patch
Test cbs_sei code paths through the user-facing h264_metadata BSF interface, as suggested by jkqxz, rather than with direct unit tests against the unstable internal CBS API. New tests: - fate-cbs-h264-metadata-set-user-data: exercises ff_cbs_sei_add_message via the sei_user_data option (SEI_TYPE_USER_DATA_UNREGISTERED). - fate-cbs-h264-metadata-set-aud: exercises AUD NAL unit insertion. - fate-cbs-h264-metadata-set-display-orientation: exercises ff_cbs_sei_add_message and ff_cbs_sei_find_message via the display_orientation=insert option (SEI_TYPE_DISPLAY_ORIENTATION). >From 09f4d79d7e1eef36ea8daab8cfbc6b5d6169ac70 Mon Sep 17 00:00:00 2001 From: Sankalpa Sarkar <[email protected]> Date: Wed, 15 Apr 2026 14:55:58 +0530 Subject: [PATCH] fate/cbs: add h264_metadata BSF tests exercising SEI handling Test cbs_sei code paths through the user-facing h264_metadata BSF interface, as suggested by jkqxz, rather than with direct unit tests against the unstable internal CBS API. New tests: - fate-cbs-h264-metadata-set-user-data: exercises ff_cbs_sei_add_message via the sei_user_data option (SEI_TYPE_USER_DATA_UNREGISTERED). - fate-cbs-h264-metadata-set-aud: exercises AUD NAL unit insertion. - fate-cbs-h264-metadata-set-display-orientation: exercises ff_cbs_sei_add_message and ff_cbs_sei_find_message via the display_orientation=insert option (SEI_TYPE_DISPLAY_ORIENTATION). --- tests/fate/cbs.mak | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/tests/fate/cbs.mak b/tests/fate/cbs.mak index d9200debc9..4971fab89a 100644 --- a/tests/fate/cbs.mak +++ b/tests/fate/cbs.mak @@ -102,6 +102,23 @@ $(foreach N,$(FATE_CBS_DISCARD_TYPES),$(eval $(call FATE_CBS_DISCARD_TEST,h264,$ FATE_CBS_H264-$(call ALLYES, MOV_DEMUXER H264_MUXER H264_PARSER FILTER_UNITS_BSF H264_METADATA_BSF) += $(FATE_CBS_h264_DISCARD) +# H.264 metadata BSF tests + +fate-cbs-h264-metadata-set-user-data: CMD = md5 -i $(TARGET_SAMPLES)/h264-conformance/SVA_Base_B.264 -c:v copy -bsf:v "h264_metadata=sei_user_data=dc45e9bde2d19e43+hello" -f h264 +fate-cbs-h264-metadata-set-user-data: CMP = oneline +fate-cbs-h264-metadata-set-user-data: REF = 0000000000000000000000000000dead +FATE_CBS_H264-$(call ALLYES, H264_DEMUXER H264_METADATA_BSF H264_MUXER) += fate-cbs-h264-metadata-set-user-data + +fate-cbs-h264-metadata-set-aud: CMD = md5 -i $(TARGET_SAMPLES)/h264-conformance/SVA_Base_B.264 -c:v copy -bsf:v h264_metadata=aud=insert -f h264 +fate-cbs-h264-metadata-set-aud: CMP = oneline +fate-cbs-h264-metadata-set-aud: REF = 0000000000000000000000000000dead +FATE_CBS_H264-$(call ALLYES, H264_DEMUXER H264_METADATA_BSF H264_MUXER) += fate-cbs-h264-metadata-set-aud + +fate-cbs-h264-metadata-set-display-orientation: CMD = md5 -i $(TARGET_SAMPLES)/h264-conformance/SVA_Base_B.264 -c:v copy -bsf:v "h264_metadata=display_orientation=insert:rotate=90" -f h264 +fate-cbs-h264-metadata-set-display-orientation: CMP = oneline +fate-cbs-h264-metadata-set-display-orientation: REF = 0000000000000000000000000000dead +FATE_CBS_H264-$(call ALLYES, H264_DEMUXER H264_METADATA_BSF H264_MUXER) += fate-cbs-h264-metadata-set-display-orientation + FATE_SAMPLES_FFMPEG += $(FATE_CBS_H264-yes) fate-cbs-h264: $(FATE_CBS_H264-yes) -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
