On Tue, Sep 8, 2015 at 4:22 PM, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Tue, Sep 8, 2015 at 9:17 PM, Ganesh Ajjanagadde > <gajjanaga...@gmail.com> wrote: >> Previous color support relies on existence of tput. >> Unfortunately, tput is not available on windows. >> According to >> https://stackoverflow.com/questions/19710074/tput-color-definitions-for-windows-git-shell, >> using ANSI color codes for Windows should be safe. >> Thus, tput is used whenever possible; and falls back to ANSI codes when it >> is unavailable. >> >> Untested on Windows. > > Just so I get this right .. you are building a patch for Windows > (where tput isnt present), yet you cannot or do not test on Windows? > Seems like someone else that cares about this should do this, like, > someone that can actually test.
Yes, and I don't see why this is a serious issue. Ideally yes; someone with the platform can do a more thorough job - but I fail to see why if one can't develop for some platform and others test for that platform. A concrete instance of this (one I was involved with) was a trivial change to silence a large array of warnings on solaris: commit 531b0a316. I do not have a solaris environment, Michael has one. I was pretty confident that it would work and Michael tested it. > > Oh, and if i start seeing weird broken ANSI escape codes in my > terminal, I will revert. :p Of course. > > - Hendrik > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
