> -----Original Message-----
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> Of Stefano Sabatini
> Sent: Tuesday, September 08, 2015 11:52 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH] lavc/libopenh264enc: apply minor
> consistency fixes to options text
>
> On date Tuesday 2015-09-08 16:41:57 +0200, Clément Bœsch encoded:
> > On Tue, Sep 08, 2015 at 03:59:58PM +0200, Stefano Sabatini wrote:
> > > ---
> > > libavcodec/libopenh264enc.c | 12 ++++++------
> > > 1 file changed, 6 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/libavcodec/libopenh264enc.c
> > > b/libavcodec/libopenh264enc.c index b315e8b..84a9cb1 100644
> > > --- a/libavcodec/libopenh264enc.c
> > > +++ b/libavcodec/libopenh264enc.c
> > > @@ -46,12 +46,12 @@ typedef struct SVCContext { #define OFFSET(x)
> > > offsetof(SVCContext, x) #define VE AV_OPT_FLAG_VIDEO_PARAM |
> > > AV_OPT_FLAG_ENCODING_PARAM static const AVOption options[] = {
> > > - { "slice_mode", "Slice mode", OFFSET(slice_mode),
> AV_OPT_TYPE_INT, { .i64 = SM_AUTO_SLICE }, SM_SINGLE_SLICE,
> SM_RESERVED, VE, "slice_mode" },
> > > - { "fixed", "A fixed number of slices", 0, AV_OPT_TYPE_CONST, { .i64 =
> SM_FIXEDSLCNUM_SLICE }, 0, 0, VE, "slice_mode" },
> > > - { "rowmb", "One slice per row of macroblocks", 0,
> AV_OPT_TYPE_CONST, { .i64 = SM_ROWMB_SLICE }, 0, 0, VE, "slice_mode" },
> > > - { "auto", "Automatic number of slices according to number of
> threads", 0, AV_OPT_TYPE_CONST, { .i64 = SM_AUTO_SLICE }, 0, 0, VE,
> "slice_mode" },
> > > - { "loopfilter", "Enable loop filter", OFFSET(loopfilter),
> AV_OPT_TYPE_INT, { .i64 = 1 }, 0, 1, VE },
> > > - { "profile", "Set profile restrictions", OFFSET(profile),
> AV_OPT_TYPE_STRING, { 0 }, 0, 0, VE },
> >
> > > + { "slice_mode", "set lice mode", OFFSET(slice_mode),
"set lice mode" probably should be "set slice mode".
> > > + AV_OPT_TYPE_INT, { .i64 = SM_AUTO_SLICE }, SM_SINGLE_SLICE,
> > > + SM_RESERVED, VE, "slice_mode" },
> >
> > slice
>
> Locally fixed.
>
> > > + { "fixed", "a fixed number of slices", 0, AV_OPT_TYPE_CONST, {
> > > .i64
> = SM_FIXEDSLCNUM_SLICE }, 0, 0, VE, "slice_mode" },
> > > + { "rowmb", "one slice per row of macroblocks", 0,
> AV_OPT_TYPE_CONST, { .i64 = SM_ROWMB_SLICE }, 0, 0, VE, "slice_mode" },
> > > + { "auto", "automatic number of slices according to number of
> threads", 0, AV_OPT_TYPE_CONST, { .i64 = SM_AUTO_SLICE }, 0, 0, VE,
> "slice_mode" },
> > > + { "loopfilter", "enable loop filter", OFFSET(loopfilter),
> AV_OPT_TYPE_INT, { .i64 = 1 }, 0, 1, VE },
> > > + { "profile", "set profile restrictions", OFFSET(profile),
> > > + AV_OPT_TYPE_STRING, { 0 }, 0, 0, VE },
> > > { NULL }
> > > };
> >
> > rest LGTM
>
> Will push soon, thanks.
> --
> FFmpeg = Fabulous and Friendly Merciful Powered Epic Geisha
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
