On Sat, Sep 5, 2015 at 8:08 AM, proud zhu <proudzhu....@gmail.com> wrote: > this patch fix the below error when build with --enable-libfreetype > libavfilter/avf_showcqt.c:38:10: error: #include expects "FILENAME" or > <FILENAME> > #include FT_FREETYPE_H
I noticed that this does not affect clang, while it does affect gcc. Note that this "computed include" stuff is rather arcane, see e.g https://gcc.gnu.org/onlinedocs/cpp/Computed-Includes.html. Your patch does not seem to cause any issues, and fixes an issue on GCC. However, I do not like the patch as is; and suggest the following improvement: Expand the commit message to reflect the above analysis, i.e mention that this is compiler specific (GCC and not clang), and also that it fixes a multitude of such errors. You don't have to list all of them if there are too many, but at least change "fix the below error" to "fix errors of the form ...". > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
