On Sat, Sep 05, 2015 at 07:11:39AM -0400, Ronald S. Bultje wrote:
> This prevents the following warning: "Application provided invalid, non
> monotonically increasing dts to muxer in stream 0: 9 >= 9".
> ---
> libavformat/md5enc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/md5enc.c b/libavformat/md5enc.c
> index 8e87f09..e1a5368 100644
> --- a/libavformat/md5enc.c
> +++ b/libavformat/md5enc.c
> @@ -107,7 +107,8 @@ AVOutputFormat ff_md5_muxer = {
> .write_header = write_header,
> .write_packet = write_packet,
> .write_trailer = write_trailer,
> - .flags = AVFMT_NOTIMESTAMPS,
> + .flags = AVFMT_VARIABLE_FPS | AVFMT_TS_NONSTRICT |
> + AVFMT_TS_NEGATIVE,
> .priv_class = &md5enc_class,
> };
> #endifThe warning indicates a problem, I dont think we should "remove" the warning without fixing the problem also some kind of md5 checksum muxer which validates timestamps for regression tests should be kept. Validating timestamps is important Tests which pass timestamp validation currently should raise a big red flag when they fail. Ive not checked but i suspect md5 would not give any indication that good valid timestamps changed into bad invalid ones, it would give the same checksum with no warnings either way That would be rather bad for regression tests as worsening timestamp validity could be easily missed [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 3 "Rare item" - "Common item with rare defect or maybe just a lie" "Professional" - "'Toy' made in china, not functional except as doorstop" "Experts will know" - "The seller hopes you are not an expert"
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
