On 8/3/2025 10:28 AM, Michael Niedermayer wrote:
On Sun, Aug 03, 2025 at 03:26:00PM +0200, Michael Niedermayer wrote:On Sun, Aug 03, 2025 at 01:45:17PM +0200, Timo Rothenpieler wrote:On 8/3/2025 9:41 AM, Michael Niedermayer wrote:Hican we have a tag that causes "automerge on approve" ? so that if i open a pr i can set that tag and if someone approves it, its merged and i dont have to come back and click that button ?That is how it should already work normally. If there is no approval, the merge button turns into a "Auto-Merge when checks succeed", and "at least one approval" is said check. Not sure if being an admin lets you bypass that, but at least I also see the "Rebase then fw (When checks succeed)" button.ok lets see if that works I saw one button and i clicked it on "https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20093";to clarify, i clicked it twice, once does nothing
If i recall correctly, for whatever reason the first time you click it you're selecting one of two or more options it gives you (rebase+ff vs merge commit, but i assume the latter is not allowed), then the second click is to confirm that selection. It's kinda weird and clunky.
lets see if it waits for an approval :) btw how exactly does that work when a pull request crosses the area of knowledge of 5 people ? thx[...] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
