On Tue, Sep 1, 2015 at 4:34 PM, Sailaja Mahendrakar <smahendra...@rgbnetworks.com> wrote: > Thank you for the comments Carl! > I have applied the review comments and attached is the updated patch. > > Sailaja > > -----Original Message----- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Carl > Eugen Hoyos > Sent: Tuesday, September 01, 2015 2:37 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH]ExtraData computation for aac in -acodec > copy > > Sailaja Mahendrakar <smahendrakar <at> rgbnetworks.com> writes: > >> Please find attached the patch for ExtraData computation for aac in >> -acodec copy. With audio codec copy, there is no extradata >> computation and RTMP fails with no audio in playback. > > I don't know if it is acceptable what the patch does, so please wait for a > review from an api expert, but before the patch can be applied, please fix > the style to make it similar to the rest of the file: >
Carl is correct to worry - a decoder cannot allocate and write extradata, thats not allowed in the API contract. Otherwise it may end up not being free'ed, or potentially free'ed by the wrong function. I'm afraid your approach is not practical. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
