Re: [FFmpeg-devel] [PATCH] avfilter/codecview/WIP: add QP support

[Clément Bœsch]

On Mon, Aug 31, 2015 at 04:30:47PM +0200, Michael Niedermayer wrote:
> On Mon, Aug 31, 2015 at 03:29:03PM +0200, Clément Bœsch wrote:
> > From: Clément Bœsch <clem...@stupeflix.com>
> > 
> > ---
> > I'm not sure I'm doing the correct thing here, but maybe that's just 
> > because my
> > samples aren't relevant.
> > 
> > TODO: doc
> > ---
> >  libavfilter/vf_codecview.c | 43 ++++++++++++++++++++++++++++++++++++++++++-
> >  1 file changed, 42 insertions(+), 1 deletion(-)
> > 
> > diff --git a/libavfilter/vf_codecview.c b/libavfilter/vf_codecview.c
> > index df45f55..5e1334e 100644
> > --- a/libavfilter/vf_codecview.c
> > +++ b/libavfilter/vf_codecview.c
> > @@ -27,7 +27,6 @@
> >   * libavcodec/mpegvideo.c.
> >   *
> >   * TODO: segmentation
> > - * TODO: quantization
> >   */
> >  
> >  #include "libavutil/imgutils.h"
> > @@ -43,11 +42,14 @@
> >  typedef struct {
> >      const AVClass *class;
> >      unsigned mv;
> > +    int hsub, vsub;
> > +    int qp;
> >  } CodecViewContext;
> >  
> >  #define OFFSET(x) offsetof(CodecViewContext, x)
> >  #define FLAGS AV_OPT_FLAG_FILTERING_PARAM|AV_OPT_FLAG_VIDEO_PARAM
> >  static const AVOption codecview_options[] = {
> > +    { "qp", NULL, OFFSET(qp), AV_OPT_TYPE_INT, {.i64=0}, 0, 1, .flags = 
> > FLAGS },
> >      { "mv", "set motion vectors to visualize", OFFSET(mv), 
> > AV_OPT_TYPE_FLAGS, {.i64=0}, 0, INT_MAX, FLAGS, "mv" },
> 
> this breaks API, the order of options matters like for
> -vf codecview=7

Ah. my bad yeah, fixed locally.

-- 
Clément B.

pgpvdVOps8W_J.pgp
Description: PGP signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel