On Thu, Jun 12, 2025 at 12:27 PM Maryla Ustarroz-Calonge via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote: > ---------- Forwarded message ---------- > From: Maryla Ustarroz-Calonge <mar...@google.com> > To: ffmpeg-devel@ffmpeg.org > Cc: > Bcc: > Date: Thu, 12 Jun 2025 18:27:43 +0200 > Subject: [PATCH] avcodec/itut35: always check the provider code and country > code together > From: Maryla <mar...@google.com> > > ITU-T T.35 provider codes are attributed by national bodies and it's > possible to have collisions across countries. This is why the country code > must always be checked as well. > In the code this could be done by having an outer switch on the country code, > then an inner switch on the provider code, but this would add an extra level > of > indentation and is not necessary as long as the codes used don't collide. > > Rename some of the constants to match the corresponding organization. > Add a constant for AOM. > Write all constants with 4 hex digits to make it clear that they are 2-byte > ids.
While it's a bit more annoying, I think the checks should actually be inverted. It should be looking at the country codes first, and then within those country codes it should look at the provider. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
