All the comments were addressed, except the prefetch one in the patch version 2 I sent earlier today. And how did you test the prefetch, because I literally run a native benchmarking on the device right now and I see that with the patch applied I am getting 5% of performance improvement. Maybe there is an issue in the way you measure the timers? I can for sure remove them because I anyway use my own implementation that is 5-10x faster than the ffmpeg's, but I am genuinely curious how is it possible that you see different benchmarking results.
> On May 30, 2025, at 09:09, Martin Storsjö <mar...@martin.st> wrote: > > On Thu, 29 May 2025, Dmitriy Kovalenko wrote: > >> I appreciate the review for both the commits. I did fix all the unrelated >> changes and iterated in the new version, would appreciate the rearview. > > Don't top post. > > There are still at least 5 of my comments unaddressed. If you are not going > to address them, then you need to respond to the comments and explain why you > think the change should be kept as is. > > // Martin > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
