Andreas Rheinhardt: > Martin Storsjö: >> On Thu, 22 May 2025, James Almer wrote: >> >>> ffmpeg | branch: master | James Almer <jamr...@gmail.com> | Thu May 22 >>> 19:23:35 2025 -0300| [622a72b5ea5f2022b173355d65d513df2d75000b] | >>> committer: James Almer >>> >>> tests/fate/ac3: add a second ac3_fixed encoder test >>> >>> Exercising the lavfi filtergraph codepath to choose the best output >>> layout. >>> >>> Signed-off-by: James Almer <jamr...@gmail.com> >>> >>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/? >>>> a=commit;h=622a72b5ea5f2022b173355d65d513df2d75000b >>> --- >>> >>> tests/fate/ac3.mak | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/tests/fate/ac3.mak b/tests/fate/ac3.mak >>> index 1ecb5a3f54..b23a9e4dcc 100644 >>> --- a/tests/fate/ac3.mak >>> +++ b/tests/fate/ac3.mak >>> @@ -91,6 +91,11 @@ fate-ac3-fixed-encode: CMD = md5 -i $(SRC) -c >>> ac3_fixed -ab 128k -f ac3 -flags + >>> fate-ac3-fixed-encode: CMP = oneline >>> fate-ac3-fixed-encode: REF = e9d78bca187b4bbafc4512bcea8efd3e >>> >>> +FATE_AC3-$(call ALLYES, EAC3_DEMUXER AC3_FIXED_ENCODER AC3_MUXER >>> ARESAMPLE_FILTER) += fate-ac3-fixed-encode-2 >>> +fate-ac3-fixed-encode-2: CMD = md5pipe -i $(TARGET_SAMPLES)/eac3/ >>> the_great_wall_7.1.eac3 -c:a ac3_fixed -ab 256k -f ac3 -flags >>> +bitexact -af aresample >>> +fate-ac3-fixed-encode-2: CMP = oneline >>> +fate-ac3-fixed-encode-2: REF = 1b92b037b23b231c9523f334ccfb11da >>> + >>> FATE_EAC3-$(call ALLYES, EAC3_DEMUXER EAC3_MUXER EAC3_CORE_BSF) += >>> fate-eac3-core-bsf >>> fate-eac3-core-bsf: CMD = md5pipe -i $(TARGET_SAMPLES)/eac3/ >>> the_great_wall_7.1.eac3 -c:a copy -bsf:a eac3_core -fflags +bitexact - >>> f eac3 >>> fate-eac3-core-bsf: CMP = oneline >> >> This test seems to fail in a large number of configurations; see fate. >> > > Presumably because it does not use the ac3_fixed decoder? > And why was this not on the mailing list? (That's a question for James, > not for you.) >
The fixed point ac3 decoder also uses floats, so it also may not work. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
